Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dotenv is a devDependency #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xFlicker
Copy link

  • not always installed
  • is a user concern
  • process.env not read in this file
    apparently a lockfile updated to the latest version of airstack/frames in the process of npm i? eh? recursive lock?

 - not always installed
 - is a user concern
 - process.env not read in this file
@YosephKS
Copy link
Collaborator

YosephKS commented Aug 6, 2024

  • not always installed
  • is a user concern
  • process.env not read in this file
    apparently a lockfile updated to the latest version of airstack/frames in the process of npm i? eh? recursive lock?

Hi @0xFlicker not really sure what the issue here, as I don't see the connection between the problem you've written here with the commit you made

If you can make your description more specific, will appreciate it 🙏🏼

Can you let me know more details if this is fixing any certain issue?

@0xFlicker
Copy link
Author

dotenv is a devDependency, not a dependency

so if you install @airstack/frames into a package that does NOT have dotenv installed, then @airstack/frames will refuse to load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants