fix: Revert grpcio and protobuf to versions compatible with litellm#4780
Open
mmangkad wants to merge 1 commit intoAider-AI:mainfrom
Open
fix: Revert grpcio and protobuf to versions compatible with litellm#4780mmangkad wants to merge 1 commit intoAider-AI:mainfrom
mmangkad wants to merge 1 commit intoAider-AI:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a dependency conflict introduced when google-generativeai was removed, which inadvertently bumped grpcio and protobuf to versions incompatible with litellm, breaking Docker builds.
Changes:
- Reverted
grpcioandgrpcio-statusfrom 1.76.0 to 1.67.1 - Reverted
protobuffrom 6.33.4 to 5.29.5
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements/requirements-dev.txt | Reverted grpcio, grpcio-status, and protobuf to versions compatible with litellm |
| requirements/common-constraints.txt | Updated constraint versions for grpcio, grpcio-status, and protobuf to match compatibility requirements |
| requirements.txt | Reverted grpcio to 1.67.1 to satisfy litellm's version constraints |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The recent removal of
google-generativeai(commit d91c02c) inadvertently bumpedgrpcioto1.76.0andprotobufto6.33.4. This caused a dependency conflict becauselitellmandgrpcio-statusrequire earlier versions, breaking the Docker build and installation. See error below when running./benchmark/docker_build.sh:Modifications
This PR reverts:
grpcioto1.67.1grpcio-statusto1.67.1protobufto5.29.5Tests
Verified that
./benchmark/docker_build.shnow completes successfully.cc @paul-gauthier