fix: handle surrogate encoding errors in show_messages on Windows#4768
Open
ThanhNguyxn wants to merge 1 commit intoAider-AI:mainfrom
Open
fix: handle surrogate encoding errors in show_messages on Windows#4768ThanhNguyxn wants to merge 1 commit intoAider-AI:mainfrom
ThanhNguyxn wants to merge 1 commit intoAider-AI:mainfrom
Conversation
Fixes Aider-AI#3844 Emoji characters pasted from Windows clipboard can contain invalid surrogate pairs that cause UnicodeEncodeError when printing to the console in verbose mode (-v). Added try/except around print() to catch UnicodeEncodeError and fall back to encoding with surrogatepass before printing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3844
Emoji characters pasted from Windows clipboard can contain invalid surrogate pairs that cause
UnicodeEncodeError: 'utf-8' codec can't encode characters ... surrogates not allowedwhen printing to the console in verbose mode (-v).Root Cause
In
utils.pyline 139,print(formatted_output)directly prints the message content. When the content contains surrogate characters from emoji input, Python's print() fails with UnicodeEncodeError.Fix
Added try/except around
print()inshow_messages()to catchUnicodeEncodeErrorand fall back to encoding withsurrogatepasserror handler, then decoding withreplaceto substitute problematic characters:This prevents the crash while still displaying readable output.