fix: prevent KeyError when custom commit_prompt contains curly braces#4766
Open
ThanhNguyxn wants to merge 1 commit intoAider-AI:mainfrom
Open
fix: prevent KeyError when custom commit_prompt contains curly braces#4766ThanhNguyxn wants to merge 1 commit intoAider-AI:mainfrom
ThanhNguyxn wants to merge 1 commit intoAider-AI:mainfrom
Conversation
Fixes Aider-AI#4719 The get_commit_message function used str.format() to substitute {language_instruction} in the commit prompt. If a user provides a custom --commit-prompt that contains other curly braces like {message}, this causes a KeyError. Changed str.format() to str.replace() to only substitute the specific placeholder without interpreting other curly brace patterns.
|
Looks good, simple bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4719
Changed
str.format()tostr.replace()inget_commit_message()to prevent KeyError when custom commit prompts contain curly braces like{message}.Root Cause
The code used:
When custom
--commit-promptcontains{message}or other{placeholder}, Python raises KeyError.Fix
This only substitutes the specific placeholder without interpreting other curly braces.