Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agoric-cli lib export #10611

Merged
merged 3 commits into from
Dec 4, 2024
Merged

agoric-cli lib export #10611

merged 3 commits into from
Dec 4, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Dec 3, 2024

refs: #9109

Description

#9109 packaged up @agoric/client-utils but left duplicated in a3p-integration the files copied from agoric-cli.

This makes agoric-cli export its lib modules and uses the yarn link established in 9109 to import them.

Security Considerations

agoric-cli package now exports the libraries it uses.

Scaling Considerations

none

Documentation Considerations

The libs of agoric-cli are not yet stabilized, but since the agoric CLI is at 0.21 it doesn't claim to maintain backwards compatibility.

Testing Considerations

CI

Upgrade Considerations

n/a

Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ce6d56
Status: ✅  Deploy successful!
Preview URL: https://730416d3.agoric-sdk.pages.dev
Branch Preview URL: https://ta-a3p-test-lib.agoric-sdk.pages.dev

View logs

@turadg turadg marked this pull request as ready for review December 3, 2024 16:59
@turadg turadg requested a review from a team as a code owner December 3, 2024 16:59
@turadg turadg added the force:integration Force integration tests to run on PR label Dec 3, 2024
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Dec 3, 2024
@turadg turadg force-pushed the ta/a3p-test-lib branch 2 times, most recently from e23d7b4 to 85aceaa Compare December 3, 2024 23:42
@turadg
Copy link
Member Author

turadg commented Dec 3, 2024

@mergify requeue

Copy link
Contributor

mergify bot commented Dec 3, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 3314b25 into master Dec 4, 2024
81 checks passed
@mergify mergify bot deleted the ta/a3p-test-lib branch December 4, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants