feat(provisionPool): allow overriding PerAccountInitialAmount
during contract upgrade
#10594
+71
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10562
Description
Note: this PR is currently defined as "DRAFT" because it should land after #10419
This PR updates the provisionPool contract to allow overriding the PerAccountInitialAmount parameter, which is governed by the Economic Committee during contract upgrades.
To achieve the above functionality, this PR introduces the following changes:
The core-eval proposal used to upgrade provisionPool was also updated to fetch the current value of PerAccountInitialAmount set on Vstorage and include it on the new privateArgs
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
I have confirmed that the existing unit tests built for provisionPool continue to pass.
Along with the existing tests, these changes were also tested against the governance acceptance test, at a3p-integration, where one of the test cases is to ensure that the governed parameter values are intact after a contract upgrade.
That test is not included here to limit the scope of this PR.
Upgrade Considerations