lint multichain-testing #10312
Merged
lint multichain-testing #10312
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
approved these changes
Oct 22, 2024
| "lint": "yarn lint:eslint", | ||
| "lint:eslint": "eslint .", | ||
| "lint:types": "tsc --noEmit", | ||
| "lint": "yarn tsc && yarn eslint .", |
There was a problem hiding this comment.
🎉 at one point, i don't think this was possible due to type errors from dependencies
turadg
force-pushed
the
ta/lint-multichain
branch
from
73c43fb
to
7d28066
Compare
Deploying agoric-sdk with
|
| Latest commit: |
a62f80c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6967acdf.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-lint-multichain.agoric-sdk.pages.dev |
turadg
force-pushed
the
ta/lint-multichain
branch
2 times, most recently
from
4385b85
to
f711d5f
Compare
turadg
force-pushed
the
ta/lint-multichain
branch
3 times, most recently
from
7852746
to
a30b8d1
Compare
turadg
force-pushed
the
ta/lint-multichain
branch
from
a30b8d1
to
a62f80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
#10305 used
bypass:integrationbecause it was just a change to linting, which should run before integration tests.Unfortunately, that broke master because
multichain-testinguses the same tsconfig and isn't run until integration.Then I noticed its lint doesn't include TypeScript and had many errors.
This adds
tscto itsyarn lintand fixes everything needed to get it passing.It still doesn't bring linting of
multichain-testingearlier than the Multichain E2E Tests workflow. So I still wouldn't have noticed the type import failure underbypass:integration. I don't think solving that is really worth the effort at this point.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
n/a