Add tests to address lookup / address component #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes address lookup reseting state after country * changeset (cherry picked from commit c5eba2a)
m1aw
requested review from
marcperez,
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 305d424 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
m1aw
changed the title
m1aw
changed the title
size-limit report 📦
|
|
Size Change: 0 B Total Size: 768 kB ℹ️ View Unchanged
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests to address search and the country change selector logic in the address component. This test actually uses testing library to ready the form values instead of getting them from the data object.
The first logic that is tested is when we change country. We want to reset the state field when we change country manually, and we also want to tigger validations on the test of the fields like postal code.
When we are using the address search we don't want to reset the state field, and we actually want to display it's correct value. Additionally we want to tigger validation in all the field including postal code, like above.
Tested scenarios
Fixed issue: