Fix address lookup reseting state after country #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1aw
requested review from
marcperez,
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 1273da3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -3 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
sponglord
approved these changes
Oct 28, 2024
Merged
|
m1aw
added a commit
that referenced
this pull request
Oct 28, 2024
* fixes address lookup reseting state after country * changeset (cherry picked from commit c5eba2a)
m1aw
added a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to fix the bug reported in the issue where address or field were not being pre-filled correctly.
The issue was caused by the logic that applies on the country change hook, that resets the
stateOrProvinceSelect, and re-triggers postal code validation.This hook exists because we want to reset the
stateOrProvincefield when a country changes. This was also triggering when setting country viasetSearchData, which lead to a race condition wherestateOrProvincewould be reset right after being set bysetSearchData, because of the country change.Tested scenarios
billingAddressAllowedCountriesis set to just one countryFixed issue:
#2832