Skip to content

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the capital service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 15, 2026 14:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Adyen Capital API by introducing a wide array of new models and services. These additions enable more granular management of financial grants, disbursements, and diverse international bank account identifications, reflecting an updated OpenAPI specification for the Capital service.

Highlights

  • New Capital API Models: Introduced a comprehensive suite of new data models for the Capital API, covering various financial entities such as Amount, Balance, Action, Counterparty, Disbursement, Fee, FundsCollection, Grant, GrantAccount, GrantOffer, Repayment, and ThresholdRepayment.
  • Extensive Bank Account Identification Support: Added detailed local bank account identification models for numerous countries including Australia, Brazil, Canada, Czech Republic, Denmark, Hong Kong, Hungary, New Zealand, Poland, Sweden, Singapore, United Kingdom, and United States, alongside generic IBAN and NumberAndBic identification.
  • New Capital API Services: Implemented new API services: GrantAccountsApi for managing grant accounts, GrantOffersApi for handling grant offers, and GrantsApi for managing grants and their disbursements.
  • OpenAPI Schema Handling: Incorporated AbstractOpenApiSchema and JSON utility classes to enhance the handling of OpenAPI oneOf/anyOf schemas and improve JSON serialization/deserialization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR introduces a large number of new model and service classes for the capital service, apparently generated from an OpenAPI specification. My review has identified a few systematic issues in the generated code that should be addressed in the generator templates to improve code quality and prevent potential bugs.

Specifically:

  • The equals() and hashCode() methods in many model classes incorrectly include internal state flags (isSet...), which violates their contracts and can cause issues with collections. This is a critical issue.
  • A required query parameter in GrantsApi.getAllGrants is not being enforced, which could lead to invalid API requests.
  • There's an inconsistency in how unknown enum values are handled during deserialization; some enums return null while others throw an exception. The latter is preferred for robustness.

I've provided specific examples and suggestions for these issues. Addressing them in the generator will ensure all current and future generated code is correct and consistent.

Copy link
Contributor

@jeandersonbc jeandersonbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved some comments as not applicable and the required query params is address in #1665

@jeandersonbc jeandersonbc added the Feature Indicates a new feature addition label Jan 20, 2026
@jeandersonbc jeandersonbc merged commit 9d33c74 into main Jan 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Indicates a new feature addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants