-
Notifications
You must be signed in to change notification settings - Fork 145
[capital] Code generation: update services and models #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Adyen Capital API by introducing a wide array of new models and services. These additions enable more granular management of financial grants, disbursements, and diverse international bank account identifications, reflecting an updated OpenAPI specification for the Capital service. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR introduces a large number of new model and service classes for the capital service, apparently generated from an OpenAPI specification. My review has identified a few systematic issues in the generated code that should be addressed in the generator templates to improve code quality and prevent potential bugs.
Specifically:
- The
equals()andhashCode()methods in many model classes incorrectly include internal state flags (isSet...), which violates their contracts and can cause issues with collections. This is a critical issue. - A required query parameter in
GrantsApi.getAllGrantsis not being enforced, which could lead to invalid API requests. - There's an inconsistency in how unknown enum values are handled during deserialization; some enums return
nullwhile others throw an exception. The latter is preferred for robustness.
I've provided specific examples and suggestions for these issues. Addressing them in the generator will ensure all current and future generated code is correct and consistent.
jeandersonbc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved some comments as not applicable and the required query params is address in #1665
This PR contains the automated changes for the
capitalservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.