Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPT-39] Mentors: Header covers up search bar #658

Merged
merged 8 commits into from
Nov 11, 2023

Conversation

jeffzy15
Copy link
Contributor

@jeffzy15 jeffzy15 commented Nov 7, 2023

Added padding to the navigation bar.

image

@jeffzy15 jeffzy15 requested a review from wei2912 November 7, 2023 09:26
@jeffzy15 jeffzy15 self-assigned this Nov 7, 2023
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for tender-meitner-99286b ready!

Name Link
🔨 Latest commit aa15e3e
🔍 Latest deploy log https://app.netlify.com/sites/tender-meitner-99286b/deploys/654b6c9bc5f80b0008752322
😎 Deploy Preview https://deploy-preview-658--tender-meitner-99286b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeffzy15 jeffzy15 linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do remove the changes to ResultView*.tsx flagged above. Besides these, the change to Drawer.tsx looks good to me!

components/ResultView.tsx Outdated Show resolved Hide resolved
Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wei2912 wei2912 merged commit c4443ec into AdvisorySG:multi-page Nov 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MPT-39] Mentors: Header covers up search bar
2 participants