Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nim dec dsa docs #97

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Nim dec dsa docs #97

wants to merge 4 commits into from

Conversation

nimithajalal
Copy link
Collaborator

@nimithajalal nimithajalal commented Dec 18, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to highlight this new section in a block at the top or make it more obvious/noticeable at least in the middle (like maybe an AnnouncementBlock or TitleBlock, though I realize this will change when we move to EDS, but we can look for something similar). I think we should link to the publisher profile step in the distribution page from there as well. A minor thing -- European Union(EU) just needs a space before the (EU).

Please also add the change to the changelog with a link to it, and probably should emphasize in an alert or something to make sure people notice it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants