Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for top_p in non-deterministic generation #11

Merged
merged 13 commits into from
Sep 21, 2024
Merged

Conversation

Adibvafa
Copy link
Owner

This PR adds support for top_p and more test cases for predict_dna_sequence.

@Adibvafa Adibvafa requested a review from gui11aume September 20, 2024 22:03
@Adibvafa Adibvafa self-assigned this Sep 20, 2024
@Adibvafa Adibvafa added the enhancement New feature or request label Sep 20, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@gui11aume gui11aume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I have some optional comments. The only serious one is about removing the for loop in a place where may need performance.

CodonTransformer/CodonPrediction.py Outdated Show resolved Hide resolved
CodonTransformer/CodonPrediction.py Outdated Show resolved Hide resolved
CodonTransformer/CodonPrediction.py Outdated Show resolved Hide resolved
tests/test_CodonPrediction.py Show resolved Hide resolved
tests/test_CodonPrediction.py Show resolved Hide resolved
tests/test_CodonPrediction.py Show resolved Hide resolved
tests/test_CodonPrediction.py Show resolved Hide resolved
@Adibvafa Adibvafa merged commit bca7eef into main Sep 21, 2024
3 checks passed
@Adibvafa Adibvafa deleted the prediction branch September 21, 2024 14:55
@Adibvafa
Copy link
Owner Author

Adibvafa commented Sep 22, 2024

@gui11aume Thank you for the comments, they were quite helpful! The PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants