[email protected] fix - Changed default number of passes of the Webpack TerserPlugin from 2 to 1 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the number of passes by the TerserPlugin from 2 to 1, which adds a few bytes to the output, but fixes the incompatibility with the new SWC minifier that is now default in Next.js. Required updating Webpack to a version above 5.87.0, when the ability to do this was added. Doing this created linting errors until every other package was also updated.
|
If it really works, please fix this. |
|
Please review and merge this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the number of passes by the TerserPlugin from the default of 2 to just 1, which does add a few bytes to the output, but fixes the incompatibility with the new SWC minifier that is now default in Next.js.
https://webpack.js.org/configuration/optimization/#optimizationminimizer
Required updating Webpack to a version above 5.87.0, when the ability to do this was added. Doing this created linting errors until every other package was also updated.
After building my app with this updated package, everything seemed to work correctly again.