feat: add option to customize row selection and row collapse #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasnys
force-pushed
the
customisable-checkboxes
branch
from
4e9eefc
to
bdeb367
Compare
|
Need to figure out why the tests are failing. Named blocks are only supported as of Ember 3.25+ but the |
lukasnys
added a commit
to OTA-Insight/ember-table
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version of
ember-table, you can only customize the row selection and row collapse visualisation through CSS overrides of theinput type="checkbox"element and its empty siblingspanelement.This PR aims to unlock a way of customizing the row selection and row collapse visualisation as a whole, allowing people to use their own (design system) components instead of using CSS.