-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches - Julia Bouvier #25
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,26 @@ | ||
# Improved Fibonacci | ||
|
||
# Time Complexity - ? | ||
# Space Complexity - ? (should be O(n)) | ||
# Hint, you may want a recursive helper method | ||
# Time Complexity - O(n) | ||
# Space Complexity - O(n) | ||
def fibonacci(n) | ||
|
||
raise ArgumentError.new "n must be greater than or equal to 0" if n < 0 | ||
|
||
fib_array = [0, 1] | ||
while fib_array.length < n + 1 | ||
fib_array.push(0) | ||
end | ||
|
||
if n <= 1 | ||
return n | ||
else | ||
if fib_array[n - 1] == 0 | ||
fib_array[n - 1] = fibonacci(n - 1) | ||
end | ||
if fib_array[n - 2] == 0 | ||
fib_array[n - 2] = fibonacci(n - 2) | ||
end | ||
end | ||
|
||
fib_array[n] = fib_array[n - 2] + fib_array[n - 1] | ||
return fib_array[n] | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,22 @@ | ||
# Superdigit | ||
|
||
# Time Complexity - ? | ||
# Space Complexity - ? | ||
# Time Complexity - O(n) | ||
# Space Complexity - O(n) | ||
def super_digit(n) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
end | ||
return n if n < 10 | ||
|
||
sum = 0 | ||
while n > 0 | ||
sum += n % 10 | ||
n /= 10 | ||
end | ||
|
||
return super_digit(sum) | ||
end | ||
|
||
|
||
# Time Complexity - ? | ||
# Space Complexity - ? | ||
# Time Complexity - Is this O(2^n) (exponential), because the method gets called twice each time? | ||
# Space Complexity - Is this O(2^n) (exponential), because the method gets called twice each time? | ||
Comment on lines
+18
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't exponential since the number of digits goes down by 1 with each iteration. |
||
def refined_super_digit(n, k) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
return super_digit(super_digit(n) * k) | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but the solution keeps an array of all the fibonacci numbers from 0 to n for the entire length of the recursive calls. Instead you only need to keep the last 2 fibonacci numbers.