Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Julia Bouvier #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions lib/fibonacci.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,26 @@
# Improved Fibonacci

# Time Complexity - ?
# Space Complexity - ? (should be O(n))
# Hint, you may want a recursive helper method
# Time Complexity - O(n)
# Space Complexity - O(n)
def fibonacci(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but the solution keeps an array of all the fibonacci numbers from 0 to n for the entire length of the recursive calls. Instead you only need to keep the last 2 fibonacci numbers.


raise ArgumentError.new "n must be greater than or equal to 0" if n < 0

fib_array = [0, 1]
while fib_array.length < n + 1
fib_array.push(0)
end

if n <= 1
return n
else
if fib_array[n - 1] == 0
fib_array[n - 1] = fibonacci(n - 1)
end
if fib_array[n - 2] == 0
fib_array[n - 2] = fibonacci(n - 2)
end
end

fib_array[n] = fib_array[n - 2] + fib_array[n - 1]
return fib_array[n]
end
23 changes: 15 additions & 8 deletions lib/super_digit.rb
Original file line number Diff line number Diff line change
@@ -1,15 +1,22 @@
# Superdigit

# Time Complexity - ?
# Space Complexity - ?
# Time Complexity - O(n)
# Space Complexity - O(n)
def super_digit(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Your time complexity is right, if n is the number of digits.


end
return n if n < 10

sum = 0
while n > 0
sum += n % 10
n /= 10
end

return super_digit(sum)
end


# Time Complexity - ?
# Space Complexity - ?
# Time Complexity - Is this O(2^n) (exponential), because the method gets called twice each time?
# Space Complexity - Is this O(2^n) (exponential), because the method gets called twice each time?
Comment on lines +18 to +19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't exponential since the number of digits goes down by 1 with each iteration.

def refined_super_digit(n, k)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return super_digit(super_digit(n) * k)
end

2 changes: 1 addition & 1 deletion test/super_digit_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "super_digit" do
describe "super_digit" do
it "will return 2 for super_digit(9875)" do
# Act
answer = super_digit(9875)
Expand Down