Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Emily Ball #30

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Branches - Emily Ball #30

wants to merge 9 commits into from

Conversation

eaball35
Copy link

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
What is accomplished with raise ArgumentError? It will throw an error to stop the program whenever something undesirable occurs
Why do you think we made the .all & .find methods class methods? Why not instance methods? They aren't unique behaviors for any one instance. We want to be able to call them without creating an instance
Think about the relation between Order and Customer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project? One (customer) to Many (Orders) - this is different than Solar System because each planet has one set of instructions but similar because each solar system had many planets
How is the relation between Order and Customer tracked in the CSV file? How is it tracked in your program? Why might these be different? Each customer has a customer id and each order has a order has a customer id and order id
Did the presence of automated tests change the way you thought about the problem? How? I designed my code and naming conventions around the test requirements

@jmaddox19
Copy link

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions X
Used Git Regularly X
Wave 1
All provided tests pass X
Using the appropriate attr_ for instance variables X
Wave 2
All stubbed tests are implemented fully and pass X
Used CSV library only in .all (not in .find) X
Appropriately parses the product data from CSV file in Order.all X
Order.all calls Customer.find to set up the composition relation X
Additional Notes Great job! your code looks real clean and readable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants