Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Morgan #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion lib/max_subarray.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,24 @@
# Space Complexity: ?
def max_sub_array(nums)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but no guess as to time/space complexity?

return 0 if nums == nil
return nil if nums.length == 0

curr_max_sum = nums[0]
max_sum = nums[0]
i = 1
while i < nums.length
if (curr_max_sum + nums[i]) <= nums[i]
curr_max_sum = nums[i]
elsif (curr_max_sum + nums[i]) >= nums[i]
curr_max_sum += nums[i]
end

if (curr_max_sum > max_sum)
max_sum = curr_max_sum
end
i += 1
end

return max_sum

raise NotImplementedError, "Method not implemented yet!"
end
21 changes: 20 additions & 1 deletion lib/newman_conway.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,24 @@
# Time complexity: ?
# Space Complexity: ?
def newman_conway(num)
Comment on lines 3 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but no time/space complexity estimate.

raise NotImplementedError, "newman_conway isn't implemented"
if num == 0
throw ArgumentError, "0 is not valid"
end

seq = []

seq[1] = 1
seq[2] = 1

if num == 1 || num == 2
return seq[1..num].join(' ')
end

n = 3
while n <= num
seq[n] = seq[seq[n - 1]] + seq[n- seq[n-1]]
n += 1
end

return seq[1..num].join(' ')
end
50 changes: 25 additions & 25 deletions test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,70 +1,70 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]

# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_equal 6
end

it "will work with a totally negative array" do
# Arrange
input = [-3, -4, -5, -6, -7]

# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_equal(-3)
end

it "will work with a totally negative array with the largest element at the rear" do
# Arrange
input = [ -4, -5, -6, -7, -3]

# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_equal(-3)
end

it "will work with a 1-element array" do
# Arrange
input = [3]

# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_equal 3
end

it "will return nil for an empty array" do
# Arrange
input = []

# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_be_nil
# Arrange
input = []
# Act
answer = max_sub_array(input)
# Assert
expect(answer).must_be_nil
end

it "will work for [50, -50, 50]" do
# Arrange
input = [50, -50, 50]

# Act
answer = max_sub_array(input)

# Assert
expect(answer).must_equal 50
end

end