forked from AdaGold/dynamic-programming
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaves - Hallie Johnson #14
Open
idhallie
wants to merge
2
commits into
Ada-C12:master
Choose a base branch
from
idhallie:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,21 @@ | ||
|
||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(n); it iterates over each element in the nums array once. | ||
# I don't think the max method adds meaningful time complexity. ? | ||
|
||
# Space Complexity: O(1); makes the same number of variables regardless of nums size. | ||
# Variables hold a single value and do not scale. | ||
def max_sub_array(nums) | ||
return 0 if nums == nil | ||
|
||
raise NotImplementedError, "Method not implemented yet!" | ||
return if nums == nil || nums.length == 0 | ||
|
||
max_so_far = nums[0] | ||
max_ending_here = nums[0] | ||
i = 1 | ||
|
||
while i < nums.length | ||
max_ending_here = [nums[i], max_ending_here + nums[i]].max | ||
max_so_far = [max_so_far, max_ending_here].max | ||
i += 1 | ||
end | ||
|
||
return max_so_far | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,27 @@ | ||
|
||
|
||
# Time complexity: ? | ||
# Space Complexity: ? | ||
# Time complexity: O(n); processes scale based upon num input | ||
# Space Complexity: O(n); space needs are in proportion to num input. | ||
def newman_conway(num) | ||
Comment on lines
+3
to
5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
raise NotImplementedError, "newman_conway isn't implemented" | ||
end | ||
sequence = [0, 1, 1] | ||
result = "1 1" | ||
count = 3 | ||
|
||
if num < 1 | ||
raise ArgumentError, "Input must be greater than 0." | ||
elsif num == 1 | ||
return "#{sequence[1]}" | ||
elsif num == 2 | ||
return result | ||
end | ||
|
||
while count <= num | ||
new = sequence[sequence[count - 1]] + sequence[count - sequence[ count - 1]] | ||
|
||
sequence << new | ||
result += " #{new}" | ||
count += 1 | ||
end | ||
|
||
return result | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,70 +1,70 @@ | ||
require_relative "test_helper" | ||
|
||
xdescribe "max subarray" do | ||
describe "max subarray" do | ||
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do | ||
# Arrange | ||
input = [-2,1,-3,4,-1,2,1,-5,4] | ||
|
||
# Act | ||
answer = max_sub_array(input) | ||
|
||
# Assert | ||
expect(answer).must_equal 6 | ||
end | ||
|
||
it "will work with a totally negative array" do | ||
# Arrange | ||
input = [-3, -4, -5, -6, -7] | ||
|
||
# Act | ||
answer = max_sub_array(input) | ||
|
||
# Assert | ||
expect(answer).must_equal(-3) | ||
end | ||
|
||
it "will work with a totally negative array with the largest element at the rear" do | ||
# Arrange | ||
input = [ -4, -5, -6, -7, -3] | ||
|
||
# Act | ||
answer = max_sub_array(input) | ||
|
||
# Assert | ||
expect(answer).must_equal(-3) | ||
end | ||
|
||
it "will work with a 1-element array" do | ||
# Arrange | ||
input = [3] | ||
|
||
# Act | ||
answer = max_sub_array(input) | ||
|
||
# Assert | ||
expect(answer).must_equal 3 | ||
end | ||
|
||
it "will return nil for an empty array" do | ||
# Arrange | ||
input = [] | ||
|
||
# Act | ||
answer = max_sub_array(input) | ||
|
||
# Assert | ||
expect(answer).must_be_nil | ||
# Arrange | ||
input = [] | ||
# Act | ||
answer = max_sub_array(input) | ||
# Assert | ||
expect(answer).must_be_nil | ||
end | ||
|
||
it "will work for [50, -50, 50]" do | ||
# Arrange | ||
input = [50, -50, 50] | ||
|
||
# Act | ||
answer = max_sub_array(input) | ||
|
||
# Assert | ||
expect(answer).must_equal 50 | ||
end | ||
|
||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice!