Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

working remove duplicates and longest prefix #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

working remove duplicates and longest prefix #39

wants to merge 1 commit into from

Conversation

TiffanyChio
Copy link

No description provided.

CheezItMan
CheezItMan reviewed Sep 19, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, can you use your 1st name in the PR.

Excellent work! Both methods work and the time and space complexities are right. You can do remove duplicates with better time complexity, but your solution does work.

lib/practice_exercises.rb
@@ -1,13 +1,44 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n^2)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

lib/practice_exercises.rb
end

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n) because word lengths are pretty finite, else O(m*n)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiffanyChio @CheezItMan