Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angele Z. #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Angele Z. #38

wants to merge 1 commit into from

Conversation

geli-gel
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, both methods solve the problem, but see my notes about the time and space complexities. Overall excellent work!

end
end

return list[0,new_array_length]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This technically creates a new array, so it makes your space complexity O(n)

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n) - it will always run however long the list is.
# Space Complexity: O(1) - nothing new is created
def remove_duplicates(list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a little drying up, but it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants