Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Caroline #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

stupendousC
Copy link

lol i forgot to PR it

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, both methods work. See my notes on the time complexity. Let me know if you have any questions. Overall well done!

unique_list = []

list.each do |element|
unless unique_list[-1] == element

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clever!

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!


strings.each do |string| #O(n)
if string[index] != curr_char
return match

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!




# Time Complexity: O(n^2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually O(m * n) where m is the length of the smallest string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants