Branches - Michaela #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 18, 2019
| index += 1 | ||
| else | ||
| if item == prev_num | ||
| list.delete_at(index) |
There was a problem hiding this comment.
delete_at actually shifts all the subsequent elements over 1 index. So it actually has a runtime of O(n). Since it's inside a loop running n times... Your method has a time complexity of O(n2)
| status = true | ||
| check_letter = strings[0][i] | ||
| strings.each do |string| | ||
| if string[i] != check_letter |
There was a problem hiding this comment.
If you find a letter that won't work you can stop here because any subsequent other letters can't be in the prefix.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(a * b) where a is the number of letters in the first word, and b is the number of words in the array | ||
| # Space Complexity: O(1) | ||
| def longest_prefix(strings) |
There was a problem hiding this comment.
This actually doesn't work.
Consider strings = ["carborator","carvonulted","carsome", "calsome"].
It won't work for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.