Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branches - Linnea #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Branches - Linnea #44

wants to merge 4 commits into from

Conversation

llinneaa
Copy link

@llinneaa llinneaa commented Sep 3, 2019

No description provided.

CheezItMan
CheezItMan reviewed Sep 4, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! You hit all the learning goals here. Take a look at my comment, and let me know if you have any questions.

lib/array_equals.rb
def array_equals(array1, array2)
raise NotImplementedError
if array1 == nil && array2 == nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also implement this with

if array1.nil?  && array2.nil?
  return true
elsif array1.nil? || array2.nil? # one or the other is nil, but not both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llinneaa @CheezItMan