Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Dora and Emily #13

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Branches - Dora and Emily #13

wants to merge 15 commits into from

Conversation

dora1405
Copy link

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? Method signature, block, arguments and parameters.
What are the advantages of using git when collaboratively working on one code base? Collaborators can work simultaneously on the code. There is no need to keep emailing each other the file for the other person to update/modify the code. Save time and redundancy.
What kind of relationship did you and your pair have with the unit tests? Uneven power dynamic with the unit tests. We had to pass the tests, there were no other viable alternatives.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? Used .map identify letters in user's word and upcase the words. This is helpful because it returns an array of letters that we can match to the drawn hand. We used .include? to check if letters are included in the array being referenced in order to get the points assigned to each letter for the total sum of points the word would earn.
What was one method you and your pair used to debug code? We used pry/binding pry to step through loops and find where the code broke down for unexpected outputs.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? Sustain: We did well communicating with each other, such as asking for explanation for blocks of code when one person needs clarification. Improve: We need to improve our git commit messages. Be more specific on what changes occurred and what portion of the project was worked on (i.e. Wave 1, 2, etc.).

@jmaddox19
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions X
Small commits with meaningful commit messages X
Code Requirements
draw_letters method X
Uses appropriate data structure to store the letter distribution X
All tests for draw_letters pass X
uses_available_letters? method X
All tests for uses_available_letters? pass X
score_word method X
Uses appropriate data structure to store the letter scores X
All tests for score_word pass X
highest_score_from method X
Appropriately handles edge cases for tie-breaking logic X
All tests for highest_score_from pass X
Overall Great!

Good job! Great variable names!

I'd be interested to talk with y'all about the uneven power dynamic you felt with the tests. It sounds like working with the tests wasn't a very positive experience for y'all, which makes me sad 😔

Looks really good y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants