Add browser names from Flathub #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c05bd46 in 20 seconds
More details
- Looked at
92lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/queries.ts:220
- Draft comment:
Ensure consistency in naming conventions. For example, 'Google-chrome' should be 'Google Chrome' to match the format of other entries like 'Google Chrome'. This applies to other entries as well, such as 'Google-chrome-beta' and 'Google-chrome-unstable'. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds new browser names from Flathub to thebrowser_appnamesobject. This is a straightforward addition, but there are some inconsistencies in the formatting of the entries.
Workflow ID: wflow_PJf0yqGXeq9i1n5a
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 25.98% 25.98%
=======================================
Files 27 27
Lines 1643 1643
Branches 279 292 +13
=======================================
Hits 427 427
Misses 1190 1190
Partials 26 26 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added browser names for all browsers from
FlathubBased on a report from
@collapsing_cliff_01on DiscordImportant
Add new browser names from Flathub to
browser_appnamesinqueries.tsbased on a community report.browser_appnamesinqueries.ts.chrome,firefox,librewolf,waterfox,opera,brave,edge,vivaldi, andyandex.@collapsing_cliff_01on Discord.This description was created by
for c05bd46. It will automatically update as commits are pushed.