Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvments to zsh shell plugin #1865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmdanggg2
Copy link

Fixes the shell not starting when using rez-env --norc
The originally used --rcs zsh argument does not specify an rc file as it does in bash, it simply enables reading rc files from $ZDOTDIR or $HOME. This was causing zsh to execute the rc file and exit.

Fixes broken shell prompt

@mmdanggg2 mmdanggg2 requested a review from a team as a code owner October 28, 2024 11:13
Copy link

linux-foundation-easycla bot commented Oct 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mmdanggg2 / name: James Horsley (7589243)

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (8f6f987) to head (7589243).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1865   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files         126      126           
  Lines       17217    17217           
  Branches     3017     3017           
=======================================
  Hits        10207    10207           
  Misses       6325     6325           
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso
Copy link
Member

Hi @mmdanggg2, I think I would like to get this merged and released before the next release. But before merging it, I'd like to see why our tests didn't catch this problem before. See https://github.com/AcademySoftwareFoundation/rez/blob/main/src/rez/tests/test_shells.py#L255-L265. Because the shell code is quite 🍝 and complex, I'd really like to either fix the tests that didn't detect this problem or add a new test to make sure we can detect regressions in the future.

Let me know if you need help with these tests. They can be very picky at times.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants