Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates ofxColourSpace.h #63

Closed
wants to merge 3 commits into from
Closed

Creates ofxColourSpace.h #63

wants to merge 3 commits into from

Conversation

revisionfx
Copy link
Contributor

@revisionfx revisionfx commented Oct 20, 2019

Adds two levels of support for ColourSpace. See proposal at #46.

Adds two level of support for ColourSpace.
@revisionfx revisionfx mentioned this pull request May 1, 2020
17 tasks
Added Approximate Gamma property
- Default: 1.0 - linear
- Valid Values - can be any positive value, usual suspects are 2.2, 2.4, 2.6

This property is slightly orthogonal to the other ones in this property set. The main purpose is for a plug-in to internally linearize and delinearize non-destructively in a less arbitrary way.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a lot more clarification. Is this the gamma that the plug-in should expect its input to be encoded with? Is it valid on input and output? During what calls is it valid?
In general I don't think there is enough info in this header to effectively implement this suite on either plugin or host side yet. Can some props be specified and others not? What's the expected calling/checking sequence on both sides? Maybe add a couple of worked examples or a table in the comments, so those will get into the doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some clarifications. Note this is exactly like we do in AE when user switches from project linearize versus color managed. It does not imply any processing from host, it's just data for plugins.

Added precision about Approximate Gamma
@garyo garyo closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants