Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better support for benchmarking to exrmetrics, including features from #1956:
exrmetrics /path/to/testimages/*.exr
The JSON output code is a little messy because it avoids adding a library dependency. It's possible certain outputs are invalid JSON due to missing commas or badly escaped strings, but the python test does try to parse the output.
Note this changes the JSON format of the output. Also, now requires
-o
for output file, since multiple input files are supported. Any old scripts callingexrmetrics inputfile outputfile
will now not overwrite outputfile. If outputfile already exists, it will be treated as an input and analyzed, otherwise an error will be reported. The new syntax isexrmetrics inputfile -o outputfile