Remove duplicate cmake dependency from skbuild plugin #1958
Conversation
Remove the duplicate `cmake` dependency that was added by `openexr_skbuild_plugin.py`. Scikit-build-core is adding a dependency on CMake if necessary itself, and adding one unconditionally has a side effect of installing a local PyPI version of CMake that overrides the system CMake that scikit-build-core would be using instead. This can be particularly problematic when downstream patching of CMake is required on the system in question. Fixes AcademySoftwareFoundation#1957 Signed-off-by: Michał Górny <[email protected]>
|
|
I don't seem to be able to sign the CLA since both EasyCLA and Linux Foundation's support system are both throwing internal server errors. |
|
That's odd about the EasyCLA and LF support, could you possibly try it again, in case it was a glitch on their end? Thanks! |
|
Yep, still failing. EasyCLA:
Support system:
I'm going to try mailing them. |
|
I filed a LF support ticket but didn't get much help, beyond the suggestion to try a different browser? |
|
Oh, thanks for letting me know, that made me go through some debugging and I've found the problem: I just wished people would actually give useful error messages such as "can't resolve API domain" instead of "internal errors", sigh. |
|
@mgorny, did you get past the EasyCLA error? Are you able to sign the form? Thanks! |
Yes, it's waiting for our CLA manager to approve. |
Remove the duplicate
cmakedependency that was added byopenexr_skbuild_plugin.py. Scikit-build-core is adding a dependency on CMake if necessary itself, and adding one unconditionally has a side effect of installing a local PyPI version of CMake that overrides the system CMake that scikit-build-core would be using instead. This can be particularly problematic when downstream patching of CMake is required on the system in question.Fixes #1957