Prevent crash when saving RGBA image where only one channel was added… #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Imf::FrameBuffer Do this by considering the chanstofill != channel_count case before the channel_count special cases. Signed-off-by: Peter Urbanec <[email protected]>
peterurbanec
force-pushed
the
bugfix/unpack-crash
branch
from
17245ce to
b94a658
Compare
|
@kdt3rd, does this look right to you? |
|
Huh, I really need to make that a more selection algorithm than just randomly adding tests in there. I did change this on january first, which is already merged to main, and that fix looks net identical, does that not work? |
|
I was probably too slow getting this patch out the door. Our fix was against 3.2.1 back in November 2024, but I was not able to create the merge request until January 2025. |
|
@peterurbanec, can you confirm whether the crash you saw is fixed on the main branch? |
|
We can no longer reproduce the crash in our application. |
|
Thanks for not only noticing the crash but also suggesting a fix, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to Imf::FrameBuffer
Do this by considering the chanstofill != channel_count case before the channel_count special cases.