openexr_skbuild_plugin.py adds an unnecessary cmake build requirement
#1957
Comments
mgorny
added a commit
to mgorny/openexr
that referenced
this issue
Jan 20, 2025
Remove the duplicate `cmake` dependency that was added by `openexr_skbuild_plugin.py`. Scikit-build-core is adding a dependency on CMake if necessary itself, and adding one unconditionally has a side effect of installing a local PyPI version of CMake that overrides the system CMake that scikit-build-core would be using instead. This can be particularly problematic when downstream patching of CMake is required on the system in question. Fixes AcademySoftwareFoundation#1957 Signed-off-by: Michał Górny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
openexr/src/wrappers/python/openexr_skbuild_plugin.py
Lines 103 to 106 in 66158f8
This code is unconditionally adding a dependency on
cmakePyPI project. This is inconsistent with howscikit-build-coreoperates, as it prefers using system CMake and adds the dependency only if it can't find a working version. However, the plugin effectively forces it to use the version from PyPI which is less portable, as it lacks downstream patching.Given that
scikit-build-corerequires CMake by its purpose, I don't really understand why the plugin would need to add a dependency in the first place. And if you really to do it, I think it would be better to use the same approach asscikit-build-coredoes, i.e.:https://github.com/scikit-build/scikit-build-core/blob/4fbd3b702db5157fa8c742b6c799a60adfb038e5/src/scikit_build_core/build/__init__.py#L154-L164
The text was updated successfully, but these errors were encountered: