-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add effect and marker initialization to Clip #1808
Open
peter-targett
wants to merge
4
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
peter-targett:clip-effects-markers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add effect and marker initialization to Clip #1808
peter-targett
wants to merge
4
commits into
AcademySoftwareFoundation:main
from
peter-targett:clip-effects-markers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jminor
requested changes
Nov 9, 2024
Extend Clip to allow effects and markers to be set. Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
peter-targett
force-pushed
the
clip-effects-markers
branch
from
November 9, 2024 19:31
0b95b3c
to
e786c94
Compare
Thanks for the update. Your change looks good to me. There's a build failure which I think is unrelated to your change. Let me see if we can find someone to help with that.
|
jminor
approved these changes
Nov 11, 2024
This could be a separate pull request, I note the order of the arguments between gaps and clips could be more aligned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Extend
Clip
to allow effects and markers to be set, matching howGap
's can be initialized.Reference associated tests.
Added basic C++ and Python tests.