Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effect and marker initialization to Clip #1808

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

peter-targett
Copy link
Contributor

Summarize your change.

Extend Clip to allow effects and markers to be set, matching how Gap's can be initialized.

Reference associated tests.

Added basic C++ and Python tests.

Extend Clip to allow effects and markers to be set.

Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
@jminor
Copy link
Collaborator

jminor commented Nov 11, 2024

Thanks for the update. Your change looks good to me. There's a build failure which I think is unrelated to your change. Let me see if we can find someone to help with that.

    File "/tmp/pip-build-env-hksa4rl4/overlay/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 502, in _build_extensions_serial
      self.build_extension(ext)
    File "<string>", line 70, in build_extension
    File "<string>", line 85, in build
    File "<string>", line 166, in cmake_preflight_check
  RuntimeError: CMake Error: Could not find CMAKE_ROOT !!!
  CMake has most likely not been installed correctly.
  Modules directory not found in
  /tmp/pip-build-env-hksa4rl4/overlay/share/cmake-3.31
  CMake Error: Error executing cmake::LoadCache(). Aborting.
  error: subprocess-exited-with-error

@peter-targett
Copy link
Contributor Author

This could be a separate pull request, I note the order of the arguments between gaps and clips could be more aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants