Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python build for Linux on ARM architecture #1795

Merged

Conversation

tomviner
Copy link
Contributor

@tomviner tomviner commented Sep 6, 2024

Summarize your change.

Add support for building wheels for Linux on ARM architecture.

This covers both ARM64 hardware running Linux directly, as well as Docker containers running under other operating systems, such as Docker on MacOS.

Our use case is to speed up installs of the package in Docker running on Apple M1 MacBooks.

See docs https://cibuildwheel.pypa.io/en/stable/faq/#emulation
Note there is a time penalty to building this wheel under emulation.

Copy link

linux-foundation-easycla bot commented Sep 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the ci label Sep 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (c0e97b0) to head (24ab019).
Report is 25 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   84.11%   81.62%   -2.50%     
==========================================
  Files         198      176      -22     
  Lines       22241    12345    -9896     
  Branches     4687     3026    -1661     
==========================================
- Hits        18709    10077    -8632     
+ Misses       2610     1726     -884     
+ Partials      922      542     -380     
Flag Coverage Δ
py-unittests 81.62% <ø> (-2.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 72 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d733fd...24ab019. Read the comment docs.

@mmcardle
Copy link

👍

@jminor
Copy link
Collaborator

jminor commented Sep 30, 2024

This sounds like a good idea. @tomviner can you just double check that this PR doesn't conflict/overlap with this which just landed? #1789

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 1, 2024
@tomviner
Copy link
Contributor Author

tomviner commented Oct 1, 2024

This sounds like a good idea. @tomviner can you just double check that this PR doesn't conflict/overlap with this which just landed? #1789

Good point @jminor. I've added some changes to take account of this.

Now we'll see just x86_64 and aarch64 (and not i686) getting built under the Ubuntu wheels.

Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for creating this PR!

@jminor jminor merged commit ee3e317 into AcademySoftwareFoundation:main Oct 14, 2024
56 checks passed
@tomviner tomviner deleted the build-linux-arm64-wheels branch October 14, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants