-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1677 otiotool verify ranges #1779
#1677 otiotool verify ranges #1779
Conversation
Signed-off-by: Spencer Magnusson <[email protected]>
Signed-off-by: Spencer Magnusson <[email protected]>
Signed-off-by: Spencer Magnusson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
- Coverage 84.11% 81.60% -2.52%
==========================================
Files 198 176 -22
Lines 22241 12333 -9908
Branches 4687 3031 -1656
==========================================
- Hits 18709 10064 -8645
+ Misses 2610 1733 -877
+ Partials 922 536 -386
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This change looks good to me. One thing we should clarify though is that there are plenty of cases where it is valid for an OTIO Clip to reference media outside the available range of its media. Having this tool to check for the cases where that isn't okay is helpful for sure, but that isn't always an error case. |
Agreed. Are you wanting that clarified in the verify message, or in the argument help? |
I think something brief in the usage message for that option would be wonderful. Maybe it could say something like this? "Verify that each clip in a timeline has a source range within the available range of media (acceptable in some use cases, not in others)" That would be just enough of a hint to users that it depends on the use case. Thanks :) |
Signed-off-by: Spencer Magnusson <[email protected]>
Signed-off-by: Spencer Magnusson <[email protected]>
Fixes #1677
Summary
Adds
--verify-ranges
option for otiotool's inspection feature, verifies that the clip's source range doesn't start before the available start range or ends beyond it (if the available range exists).