Fix service override #866
Merged
Fix service override #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting jobs only by priority causes a situation where low priority jobs can get starved by a constant flow of high priority jobs. The new formula adds a modifier to the sorting rank to take into account the number of cores the job is requesting and also the number of days the job is waiting on the queue. Priorities numbers over 200 will mostly override the formula and work as a priority only based scheduling. sort = priority + (100 * (1 - (job.cores/job.int_min_cores))) + (age in days) Besides that, also take layer_int_cores_min into account when filtering folder_resourse limitations to avoid allocating more cores than the folder limits. (cherry picked from commit 566411aeeddc60983a30eabe121fd03263d05525)
This reverts commit 2eb4936
DiegoTavares
requested review from
bcipriano,
gregdenton,
jrray,
larsbijl and
smith1511
as code owners
- Implements ServiceOverride wrapper class in pycue - Fixes handling of ServiceOverride objects in the GUI - Resolves bug in cuebot that incorrectly processes ServiceOverrideDeleteRequest and ServiceOverrideUpdateRequest (cherry picked from commit ab4e0c195f1f3df4f9c625b62ff9532b438ee5a4)
DiegoTavares
force-pushed
the
fix_service_override
branch
from
696abdc to
a31ae11
Compare
bcipriano
reviewed
Dec 15, 2020
DiegoTavares
commented
Jan 29, 2024
Signed-off-by: Diego Tavares da Silva <[email protected]>
|
Got a few conflicts here, needs to be resolved with master. |
Signed-off-by: Diego Tavares da Silva <[email protected]>
|
Looks like we've got some python test breakage now. |
|
Alright, this has finally passed the tests. |
bcipriano
approved these changes
Mar 5, 2024
bcipriano
merged commit 0d3cc69
into
AcademySoftwareFoundation:master
11 of 12 checks passed
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix service override delete and update operations