Reformat all java files #1627
Merged
Reformat all java files #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting was previously being handled by code_style–ij.xml which is not really compatible with many new IDEs. This PR changes formating to GoogleStyle enforced by the spotless gradle plugin in conjunction with jdtls, which is compatible with vscode and eclipse.
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
|
Update documentation to add vscode and intellij configuration |
ramonfigueiredo
approved these changes
Jan 17, 2025
|
@DiegoTavares Looks great to me! I checked the files, and the formatting changes look good. Switching to GoogleStyle with spotless and jdtls is a smart move for IDE compatibility. It would be helpful to add the Approved! FYI... |
DiegoTavares
merged commit 97e5d3f
into
AcademySoftwareFoundation:master
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting was previously being handled by code_style–ij.xml which is not really compatible with many new IDEs. This PR changes formating to GoogleStyle enforced by the spotless gradle plugin in conjunction with jdtls, which is compatible with vscode and eclipse.
Execute
gradle spotlessApplyto execute the formatter using gradle locally.