Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reverse lookup function for delegated wallets by rights #1

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

coffeexcoin
Copy link
Contributor

@coffeexcoin coffeexcoin commented Jan 8, 2025

PR-Codex overview

This PR focuses on enhancing the ExclusiveDelegateResolver contract by adding a new function to retrieve wallets delegated to a specific wallet based on rights, while also updating the test suite to cover these new functionalities.

Detailed summary

  • Updated .gitignore to include zksolc and zkout/.
  • Added abstract RPC URL in foundry.toml.
  • Modified GitHub Actions workflow to specify branches.
  • Changed visibility of exclusiveWalletByRights from external to public.
  • Introduced delegatedWalletsByRights function to return wallets delegated to a given wallet.
  • Updated tests in ExclusiveDelegateResolverTest for new functionalities, including delegation tests with multiple delegatees.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coffeexcoin coffeexcoin closed this Jan 8, 2025
@coffeexcoin coffeexcoin reopened this Jan 8, 2025
@coffeexcoin coffeexcoin merged commit 15d9fe1 into main Jan 9, 2025
1 check passed
@coffeexcoin coffeexcoin deleted the feat/reverse-lookup branch January 9, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant