Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work in reverse engineering the tfs protobuf!
I wanted to have access to flight numbers but noticed the original parser wasn't able to handle this as the information doesn't exist until you open the detailed view for each flight.
I was looking at the available data in the response and noticed that there is some static JS data that contains all the flight data. This is a little tricky though as the schema for this data is in some proprietary format (I'm guessing protobuf?) and I couldn't find an easy way to decode it.
The data is a lot of nested lists, with some value types in between. It looks like the data is well formed, so we should be able to reverse engineer the schema. I'm using the data_discovery notebook to do this.
TODO:
BTW I noticed the use of the old type annotations format (typing.List rather than list), is there any requirement to support an older python version? If not I'll change these to the new generic aliases.