Make FacetedSRPDynamicEffector variables private #1219
Merged
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module created setter and getter functions in December 2025 and using numFacets and numArticulatedFacets as public variables has been deprecated for a year now. This commit makes these two variables now module private variables that must be accessed via the module setter and getter methods.
The module RST documentation no longer needs to warn about the public use of these two variables.
schaubh
force-pushed
the
feature/remove_deprecated_items
branch
from
649a6aa to
1b318ef
Compare
leahkiner
approved these changes
Jan 5, 2026
Contributor
leahkiner
left a comment
leahkiner
left a comment
There was a problem hiding this comment.
This looks great, thank you for making this update!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A year ago the BSK module
FacetedSRPDynamicEffectorunderwent a refactor which started to use setter and getters to access module variables. The variablesnumFacetsandnumArticulatedFacetswere kept public to avoid immediately breaking code. But, their public use was departed. This branch makes these variable private and updates the module documentation.Verification
BSK built and ran without issues.
Documentation
Documentation built without issues or warnings.
Future work
None