-
Notifications
You must be signed in to change notification settings - Fork 92
Migrate supportData to on-demand fetching with Pooch #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad9ee1d to
da91cfe
Compare
6457e97 to
275cdaf
Compare
|
Local data in |
2d124e2 to
c61e2ba
Compare
dc5654b to
6336fb0
Compare
|
Updated as requested, there are two new more substantial commits 5ff0a8b and e82b6c1:
|
6336fb0 to
6e8477d
Compare
6e8477d to
e82b6c1
Compare
schaubh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor items including:
- WMM model needs updated TeX documentation on how to set path
- restore the ISC license info in a *.I file. Please don't remove these!
There is no need to automatically download BSK data as this is now handled by pooch.
e82b6c1 to
d144c13
Compare
Description
In an effort to reduce the size of basilisks wheels and shift to a more sustainable long term architecture it is desirable to not ship support data files inside the wheels. As such, we need a mechanism to fetch and cache files on demand as they are requested.
If you clone the repo most of the data is still provided directly. As before, some data such as JPL Spice data was downloaded during the build. With this branch such Spice data will now also be downloaded on demand.
To accomplish this, the way data files are loaded and used in bsk has changed drastically and now leverages Pooch to handle fetching the files. This is a library that has been battle tested by many other popular Python scientific libraries for similar reasons.
As such, this PR does the following:
bskLargeDatacommand to prefetch all dynamic data componentsVerification
CI/CD and local testing of newly built wheels verify that they do not contain the supportData files and can fetch the files using the new API.
Documentation
Future work
N/A