Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image urls #7084

Conversation

ouoertheo
Copy link

Please read the contributing wiki page before submitting a pull request!

If you have a large change, pay special attention to this paragraph:

Before making changes, if you think that your feature will result in more than 100 lines changing, find me and talk to me about the feature you are proposing. It pains me to reject the hard work someone else did, but I won't add everything to the repo, and it's better if the rejection happens before you have to waste time working on the feature.

Otherwise, after making sure you're following the rules described in wiki page, remove this section and continue on.

Describe what this pull request is trying to achieve.

Fix a bug in image_from_url_text() function. You can reproduce this bug by using the Image Browser and attempting to send an image to inpaint, which will throw an error.

Additional notes and description of your changes

final logic would not result in properly processing an image url, it would interpret as BytesIO instead of just filedata and fail.

Environment this was tested in

List the environment you have developed / tested this on. As per the contributing page, changes should be able to work on Windows out of the box.

  • OS: Windows
  • Browser: Firefox
  • Graphics card: GTX 1080

Screenshots or videos of your changes

If applicable, screenshots or a video showing off your changes. If it edits an existing UI, it should ideally contain a comparison of what used to be there, before your changes were made.

This is required for anything that touches the user interface.

@AUTOMATIC1111
Copy link
Owner

this needs to be fixed from extension side

you're making this function accept any filename in local filesystem and send it to user

@jhogsett
Copy link

@ouoertheo There's a fix here if you want to patch your local extension: yfszzx/stable-diffusion-webui-images-browser#51

@ouoertheo
Copy link
Author

this needs to be fixed from extension side

you're making this function accept any filename in local filesystem and send it to user

👍 I could certainly see problems with that. Thanks for checking it out

@ouoertheo
Copy link
Author

@ouoertheo There's a fix here if you want to patch your local extension: yfszzx/stable-diffusion-webui-images-browser#51

Awesome. I took a crack at fixing locally in the extension first, and then saw the code it was calling looked a bit odd in my eyes. Thanks!

@ouoertheo ouoertheo closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants