forked from labgrid-project/labgrid
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote: add session support for reservations and acquired places #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to check if documentation is required and add if so |
Code has been formatted by |
luke-hackwell
force-pushed
the
persist-client-connection-2
branch
2 times, most recently
from
December 18, 2024 11:20
91a1f24
to
c7a790b
Compare
alextercete
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just a few suggestions.
luke-hackwell
force-pushed
the
persist-client-connection-2
branch
from
December 19, 2024 16:22
c7a790b
to
b17e17a
Compare
alextercete
reviewed
Dec 19, 2024
alextercete
reviewed
Dec 19, 2024
alextercete
approved these changes
Dec 19, 2024
Adds a --session option to the labgrid-client monitor, reserve and acquire commands. Enables the user to setup a monitor session. Reservations and place acquisitions which are registered to the same monitor sessions will be released if the monitor session ends. Signed-off-by: Luke Hackwell <[email protected]>
luke-hackwell
force-pushed
the
persist-client-connection-2
branch
from
January 6, 2025 11:15
b17e17a
to
718edd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--session
option to thelabgrid-client
monitor
,reserve
andacquire
commands.Enables the user to setup a monitor session. Reservations and place acquisitions which are registered to the same monitor sessions will be released if the monitor session ends.
This is useful for reservations and places acquired under a CI job which may be killed without warning.
Example usage:
Checklist