Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10.x Compatibility #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laravel-shift
Copy link

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 10.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Author

⚠️ Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

@laravel-shift
Copy link
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/Localization.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "arcanedev/localization": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@CrazyBoy49z
Copy link

@arcanedev-maroc When will this PR be added?

@mkwsra
Copy link

mkwsra commented Mar 15, 2023

Is there any update on this please?

@CrazyBoy49z
Copy link

CrazyBoy49z commented Apr 19, 2023

For temporary support, Laravel 10 can be used in composer.json #173

  "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/CrazyBoy49z/Localization.git"
        },
    ],
"arcanedev/localization": "^9.0",

Replace with

"arcanedev/localization": "dev-master",
  1. A GitHub account is required
  2. Delete composer.lock and vendor
  3. composer update or composer install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants