Refactoring #cellDiscarded message creation and reception #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the way
cellDiscarded
(nowcellsDiscarded
) messages are composed, received, and ultimately handled on the Component side. This is in relation to #104Motivation and Context
See Issue #104 for details. We were sending (potentially) too many messages for discarding cells per rendering cycle
Approach
Instead of composing a single message per Cell being discarded, we now send over an array of all ids of cells to be discarded at the same time.
The CellHandler has also been updated to deal with this change.
We have changed all references to
cellDiscarded
and renamed themcellsDiscarded
How Has This Been Tested?
All existing tests are passing as normal
Screenshots or console output (if appropriate)
Types of changes
Checklist: