Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many #cellDiscarded messages #104

Open
darth-cheney opened this issue Mar 20, 2020 · 0 comments
Open

Too many #cellDiscarded messages #104

darth-cheney opened this issue Mar 20, 2020 · 0 comments
Assignees

Comments

@darth-cheney
Copy link
Contributor

As of this writing, there are two issues with sending #cellDiscarded messages that slow things down in a single rendering cycle:

  1. The message has too much information, including the type of cell etc. It only needs to reference an id.
  2. We are sending one message per each cell that is discarded in a rendering cycle. This gets to be grossly inefficient when we are, say, updating cells inside a giant table during one pass (could be thousands of separate messages).

Instead, we should restructure #cellDiscarded to instead be #cellsDiscarded which will simply pass an array of cell ids to remove per each cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant