Skip to content

Commit

Permalink
Updating intersect & loading cell placeholders (issues #118 & #119)
Browse files Browse the repository at this point in the history
Previously the "intersect frame" cells were displaying the character
'X' as their content. We have changed it so they display their actual
data values now.

Additionally, we are changing unloaded cell displays from being the
text 'undefined' to being '...'
  • Loading branch information
darth-cheney committed May 13, 2020
1 parent 04d9baf commit f735a40
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,11 @@ class PrimaryFrame extends TableElementsFrame {
if(!this.lockedFramesIntersect.isEmpty){
this.lockedFramesIntersect.forEachPoint(aPoint => {
let value = this.dataFrame.getAt(aPoint);
this.innerElementAt(aPoint).innerText = 'x';
if(value == undefined){
this.setTextContentAt(aPoint, '...');
} else {
this.setTextContentAt(aPoint, value.toString());
}
});
}
}
Expand All @@ -215,7 +219,7 @@ class PrimaryFrame extends TableElementsFrame {
if(dataValue != undefined){
this.setTextContentAt(translation, dataValue.toString());
} else {
this.setTextContentAt(translation, 'undefined');
this.setTextContentAt(translation, '...');
}
element.setAttribute('data-relative-x', aPoint.x);
element.setAttribute('data-relative-y', aPoint.y);
Expand Down Expand Up @@ -246,7 +250,7 @@ class PrimaryFrame extends TableElementsFrame {
if(dataValue != undefined){
this.setTextContentAt(translation, dataValue.toString());
} else {
this.setTextContentAt(translation, 'undefined');
this.setTextContentAt(translation, '...');
}
element.setAttribute('data-relative-x', aPoint.x);
element.setAttribute('data-relative-y', aPoint.y);
Expand Down Expand Up @@ -274,7 +278,7 @@ class PrimaryFrame extends TableElementsFrame {
if(value != undefined){
this.setTextContentAt(translation, value.toString());
} else {
this.setTextContentAt(translation, 'undefined');
this.setTextContentAt(translation, '...');
}
element.setAttribute('data-relative-x', aPoint.x);
element.setAttribute('data-relative-y', aPoint.y);
Expand Down

0 comments on commit f735a40

Please sign in to comment.