This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Fix: body parameter - empty schema to be set to empty object #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema is mandatory for body parameter
| }; | ||
|
|
||
| if (!bodyRequest.schema) { | ||
| bodyRequest.schema = {type: "object"}; |
There was a problem hiding this comment.
@tehcyx You workaround not work for non-object body, for example array.
In Swagger/JSON Schema empty schema mean anyting.
Can I replace {type: 'object'} with {}?
There was a problem hiding this comment.
+ style issue I use ' for JS code and " in JSON and JSONPath
There was a problem hiding this comment.
I wouldn't know from the top of my head if that works. But if the output will be valid Swagger we're totally fine with it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We, a team from SAP working on API Hub and YaaS, started using this converter to convert our RAML definitions into Swagger. We found that some of our RAML files were failing to convert so we had to make some changes, and we wanted to share these changes with you. We collected the list of changes we made in this CHANGELOG and will provide each fix as a different pull request for you so that you can pick the ones that you want to support.
The issue to fix
A schema is mandatory as per Open API spec for body parameters but in RAML it can be empty or undefined.
The fix
A schema of type object is added in case the schema is empty or undefined.
Best regards,
Daniel Roth - SAP Hybris