Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change constant for coherenceTime and isoplanaticAngle #95

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ojdf
Copy link
Contributor

@ojdf ojdf commented Oct 3, 2023

The constant for the coherenceTime and isoplanaticAngle functions was 0.057, but should be 0.058(1). This was causing a very small (2%) error when these quantities were calculated. Fixed to make consistent with the literature.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (0be8a2a) to head (c0fbaa1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   92.08%   92.18%   +0.10%     
==========================================
  Files          42       42              
  Lines        1997     1997              
==========================================
+ Hits         1839     1841       +2     
+ Misses        158      156       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewtownson matthewtownson merged commit 0401fa1 into AOtools:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants