Skip to content

fix: remove IP from client-side storage; store only sensitivity, invert, theme #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alishair7071 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove IP from client-side storage; store only sensitivity, invert, theme #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions src/routes/settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,10 @@ function SettingsPage() {

const [qrData, setQrData] = useState('');

// Load initial state
// Load initial state (IP is not stored in localStorage; only sensitivity, invert, theme are client settings)
useEffect(() => {
const storedIp = localStorage.getItem('rein_ip');
const defaultIp = typeof window !== 'undefined' ? window.location.hostname : 'localhost';

setIp(storedIp || defaultIp);
setIp(defaultIp);
setFrontendPort(String(CONFIG.FRONTEND_PORT));
}, []);

Expand All @@ -49,20 +47,15 @@ function SettingsPage() {
localStorage.setItem('rein_invert', JSON.stringify(invertScroll));
}, [invertScroll]);

// Effect: Update LocalStorage and Generate QR
// Generate QR when IP changes (IP is not persisted to localStorage)
useEffect(() => {
if (!ip) return;
localStorage.setItem('rein_ip', ip);

if (typeof window !== 'undefined') {
const appPort = String(CONFIG.FRONTEND_PORT);
const protocol = window.location.protocol;
const shareUrl = `${protocol}//${ip}:${appPort}/trackpad`;

QRCode.toDataURL(shareUrl)
.then(setQrData)
.catch((e) => console.error('QR Error:', e));
}
if (!ip || typeof window === 'undefined') return;
const appPort = String(CONFIG.FRONTEND_PORT);
const protocol = window.location.protocol;
const shareUrl = `${protocol}//${ip}:${appPort}/trackpad`;
QRCode.toDataURL(shareUrl)
.then(setQrData)
.catch((e) => console.error('QR Error:', e));
}, [ip]);

// Effect: Auto-detect LAN IP from Server (only if on localhost)
Expand Down